Reduce closure and Lazy allocations inside CSharpCompilation.ctor #72371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These account for about 0.3% of all allocations in the CopyPlainText speedometer test.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
sharwell
reviewed
Mar 4, 2024
sharwell
reviewed
Mar 4, 2024
sharwell
reviewed
Mar 4, 2024
Reorder bool assignment and CompareExchange to avoid potential usage of member when not initialized
sharwell
reviewed
Mar 4, 2024
sharwell
reviewed
Mar 4, 2024
|
@dotnet/roslyn-compiler -- ptal |
AlekseyTs
reviewed
Mar 5, 2024
AlekseyTs
reviewed
Mar 5, 2024
AlekseyTs
reviewed
Mar 5, 2024
AlekseyTs
reviewed
Mar 5, 2024
AlekseyTs
reviewed
Mar 5, 2024
AlekseyTs
reviewed
Mar 5, 2024
|
Done with review pass (commit 4) |
Use lazy naming convention Move away from StrongBox usage
|
@AlekseyTs any remaining concerns? |
AlekseyTs
reviewed
Mar 6, 2024
| @@ -92,11 +93,11 @@ internal Conversions Conversions | |||
| /// <summary> | |||
| /// Manages anonymous types declared in this compilation. Unifies types that are structurally equivalent. | |||
| /// </summary> | |||
| private readonly AnonymousTypeManager _anonymousTypeManager; | |||
| private AnonymousTypeManager? _anonymousTypeManager; | |||
AlekseyTs
reviewed
Mar 6, 2024
|
|
||
| private NamespaceSymbol? _lazyGlobalNamespace; | ||
|
|
||
| internal readonly BuiltInOperators builtInOperators; | ||
| private BuiltInOperators? _builtInOperators; |
AlekseyTs
reviewed
Mar 6, 2024
| @@ -152,7 +153,7 @@ internal Conversions Conversions | |||
| /// <summary> | |||
| /// Cache of T to Nullable<T>. | |||
| /// </summary> | |||
| private readonly ConcurrentCache<TypeSymbol, NamedTypeSymbol> _typeToNullableVersion = new ConcurrentCache<TypeSymbol, NamedTypeSymbol>(size: 100); | |||
| private ConcurrentCache<TypeSymbol, NamedTypeSymbol>? _typeToNullableVersion; | |||
AlekseyTs
reviewed
Mar 6, 2024
| _options = options; | ||
| _lazyScriptClass = ErrorTypeSymbol.UnknownResultType; |
|
Done with review pass (commit 5) |
RikkiGibson
reviewed
Mar 6, 2024
src/Compilers/CSharp/Portable/Symbols/Compilation_WellKnownMembers.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
approved these changes
Mar 6, 2024
3 tasks
RikkiGibson
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, lazily create a couple members that don't appear to be used on most instances. Together, these account for about 0.8% of all allocations in the CopyPlainText speedometer test.
*** Previous allocations from test profile
